feat: keep comment-hack keys above preceding key - #211
Open
forivall wants to merge 4 commits into
Open
Conversation
forivall
force-pushed
the
feat/comments
branch
from
November 26, 2020 01:58
cc1cee5 to
669ca18
Compare
fisker
reviewed
Nov 26, 2020
| // 1: comments that precede a key | ||
| // 2: trailing comments | ||
| [[], {}, []], | ||
| ) |
Collaborator
There was a problem hiding this comment.
This seems too complicated to me.
['//z', '//x', 'z', ' //name', 'name', 'a', '// end']
-> keys without `//`: ['z', 'x', 'name', 'a', 'end']
-> sort: ['a', 'end', 'name', 'x', 'z']
-> restore: ['a', `// end`, '//name', name, '//x',''x', '//z', 'z' ]WDYT?
Author
There was a problem hiding this comment.
if anyone can think of simpler ways to do this, i'm all ears.
forivall
force-pushed
the
feat/comments
branch
2 times, most recently
from
November 26, 2020 02:07
efa8868 to
b7b675f
Compare
forivall
force-pushed
the
feat/comments
branch
from
November 26, 2020 02:13
b7b675f to
7f481d3
Compare
forivall
marked this pull request as ready for review
November 26, 2020 03:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
the appropriate formatting of comments should be to put most of your comment in the key itself, like:
This is still a work in progress to add the functionality for nested things (like the
scriptsfield), but it passes the test I added, so 🎉